Skip to content

d_a_obj_kbacket matching#2479

Merged
hatal175 merged 1 commit intozeldaret:mainfrom
caseif:d_a_obj_kbacket-1
Jun 7, 2025
Merged

d_a_obj_kbacket matching#2479
hatal175 merged 1 commit intozeldaret:mainfrom
caseif:d_a_obj_kbacket-1

Conversation

@caseif
Copy link
Copy Markdown
Contributor

@caseif caseif commented Jun 7, 2025

d_a_obj_kbacket should now be matching with this PR. I haven't encountered the *_Param_c/*_HIOParam pattern before and it's currently missing code to initialize mHIO in debug config, but it's at least close enough to match in release config.

@caseif caseif force-pushed the d_a_obj_kbacket-1 branch from 9654143 to 71ed5d9 Compare June 7, 2025 04:11
@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Jun 7, 2025

Report for GZ2E01 (09fdb3e - 84b0fe2)

📈 Matched code: 63.63% (+0.07%, +7964 bytes)
📈 Linked code: 27.47% (+0.07%, +7972 bytes)

✅ 33 new matches:
Unit Function Bytes Before After
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::Execute() +3313 0.12% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::create() +932 0.43% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::~daObj_KBacket_c() +425 16.54% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::getWallAngle(short, short*) +396 1.00% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::setMtx() +301 1.32% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::Draw() +296 1.33% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::CreateHeap() +252 1.56% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::setWaterPrtcl() +244 1.61% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::calcRollAngle(short, int) +156 2.50% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::setSmokePrtcl() +120 3.23% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket __sinit_d_a_obj_kbacket_cpp +113 3.45% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket dBgS_AcchCir::~dBgS_AcchCir() +109 3.57% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket dBgS_ObjAcch::~dBgS_ObjAcch() +109 3.57% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket dCcD_GStts::~dCcD_GStts() +89 4.35% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::setEnvTevColor() +89 4.35% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::setHamonPrtcl() +76 5.00% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket cM3dGLin::~cM3dGLin() +69 5.56% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket cM3dGCyl::~cM3dGCyl() +69 5.56% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket cM3dGAab::~cM3dGAab() +69 5.56% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket cM3dGPla::~cM3dGPla() +69 5.56% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket cCcD_GStts::~cCcD_GStts() +69 5.56% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::setRoomNo() +65 5.88% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::Delete() +49 7.69% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::reset() +49 7.69% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_c::createHeapCallBack(fopAc_ac_c*) +28 12.50% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_Create(void*) +28 12.50% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_Delete(void*) +28 12.50% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_Execute(void*) +28 12.50% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket daObj_KBacket_Draw(void*) +28 12.50% 100.00%
d_a_obj_kbacket/d/actor/d_a_obj_kbacket cLib_calcTimer<int>(int*) +28 0.00% 100.00%

...and 3 more new matches

Comment thread include/d/actor/d_a_obj_kbacket.h Outdated
Comment thread src/d/actor/d_a_obj_kbacket.cpp Outdated
Comment thread src/d/actor/d_a_obj_kbacket.cpp Outdated
Comment thread src/d/actor/d_a_obj_kbacket.cpp
Comment thread src/d/actor/d_a_obj_kbacket.cpp Outdated
Comment thread src/d/actor/d_a_obj_kbacket.cpp Outdated
Comment thread src/d/actor/d_a_obj_kbacket.cpp Outdated
Comment thread src/d/actor/d_a_obj_kbacket.cpp Outdated
Comment thread src/d/actor/d_a_obj_kbacket.cpp Outdated
@caseif caseif force-pushed the d_a_obj_kbacket-1 branch from 71ed5d9 to 84b0fe2 Compare June 7, 2025 14:35
@caseif
Copy link
Copy Markdown
Contributor Author

caseif commented Jun 7, 2025

Issues should be resolved now.

@hatal175 hatal175 merged commit 1a7b145 into zeldaret:main Jun 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants